Re: [PATCH 05/15] midx: add entries to write_midx_context

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 3, 2020, 21:42 UTC
Message-ID: <xmqqim9ih8hz.fsf@gitster.c.googlers.com>
In-Reply-To: <491667de2baef422e801df1e2c7d3173462a96ff.1607012215.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> -static size_t write_midx_oid_lookup(struct hashfile *f, unsigned char hash_len,
> -				    struct pack_midx_entry *objects,
> -				    uint32_t nr_objects)
> +static size_t write_midx_oid_lookup(struct hashfile *f,
> +				    void *data)
>  {
> -	struct pack_midx_entry *list = objects;
> +	struct write_midx_context *ctx = (struct write_midx_context *)data;
> +	unsigned char hash_len = the_hash_algo->rawsz;
> +	struct pack_midx_entry *list = ctx->entries;

I know this is meant to be a faithful rewrite, but can we lose this "length of the hash function output must be smaller than 256" imposed by "unsigned char" at some point, perhaps after this series settles? .rawsz field is size_t IIRC.