Re: [PATCH 05/15] midx: add entries to write_midx_context

From: Taylor Blau <me@ttaylorr.com>
Date: Dec 8, 2020, 18:00 UTC
Message-ID: <X8+/WHBTO6GGH6Dt@nand.local>
In-Reply-To: <491667de2baef422e801df1e2c7d3173462a96ff.1607012215.git.gitgitgadget@gmail.com>

On Thu, Dec 03, 2020 at 04:16:44PM +0000, Derrick Stolee via GitGitGadget wrote:

Show 13 quoted lines

> From: Derrick Stolee <dstolee@microsoft.com>
> diff --git a/midx.c b/midx.c
> index 6ab655ddda..2af4452165 100644
> --- a/midx.c
> +++ b/midx.c
> @@ -458,6 +458,9 @@ struct write_midx_context {
>  	struct multi_pack_index *m;
>  	struct progress *progress;
>  	unsigned pack_paths_checked;
> +
> +	struct pack_midx_entry *entries;
> +	uint32_t entries_nr;
>  };

I like that you have added a newline between the members used for each of the two (so far) callback functions.

It may be helpful to add a comment to the effect of, "these are used to write the XXX chunk via write_midx_xxx()", or something.

Thanks, Taylor