Re: [PATCH 13/15] chunk-format: create chunk reading API
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 4, 2020, 20:17 UTC
- Message-ID
- <xmqq8sade360.fsf@gitster.c.googlers.com>
- In-Reply-To
- <a7be6d74-373e-e18e-b915-487bab28f438@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 17 quoted lines
> On 12/3/2020 5:17 PM, Junio C Hamano wrote: >> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: >> >>> From: Derrick Stolee <dstolee@microsoft.com> >>> >>> Now that the chunk-format API has a consistent mechanism for writing >>> file formats based on chunks, let's extend it to also parse chunk-based >>> files during read. >> >> Heads-up. The generation-data work by Abhishek would conflict with >> the way how this refactors the way the beginning offset of each >> chunk is found. > > Right! I should have checked against 'seen'. Abhishek's work should > take precedence and I can adapt on top of his topic. For now, feel > free to keep this topic out of 'seen' while we address the worth > of the topic (re: René's concerns).
Sure. We may want to do [PATCH 11/15] even if the "worth of the topic" discussion ends up negative, though.
Thanks.