Re: [PATCH] ci: do not die on deprecated-declarations warning

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 14, 2023, 16:55 UTC
Message-ID: <xmqqilh9kqdy.fsf@gitster.g>
In-Reply-To: <Y8LAim4D3g6qnZdq@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

>> +# Libraries deprecate symbols while retaining them for a long time to
>> +# keep software working with both older and newer versions of them.
>> +# Getting warnings does help the developers' awareness, but we cannot
>> +# afford to update too aggressively.  E.g. CURLOPT_REDIR_PROTOCOLS_STR
>> +# is only available in 7.85.0 that deprecates CURLOPT_REDIR_PROTOCOLS
>> +# but we cannot rewrite the uses of the latter with the former until
>> +# 7.85.0, which was released in August 2022, becomes ubiquitous.
>> +DEVELOPER_CFLAGS += -Wno-error=deprecated-declarations
>
> That's a pretty broad hammer. And I think it may stomp on the hack to
> rely on deprecated() in the UNUSED macro.

True.

> As Ramsay suggested, we could probably use CURL_DISABLE_DEPRECATION to
> limit this just to the problematic case. An even more focused option is
> to use curl's helper here:

One possible downside of the use of CURL_DISABLE_DEPRECATION is that we may still want to see deprecation warning to learn about upcoming change. We just do not want the -Werror to make us die when it happens.

But anyway, let's use CURL_DISABLE_DEPRECATION first to see how it goes.

Thanks.