Re: [PATCH 1/3] http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT
- From
Jeff King <peff@peff.net>
- Date
- Jan 15, 2023, 23:13 UTC
- Message-ID
- <Y8SIf8AyGrNflBA7@coredump.intra.peff.net>
- In-Reply-To
- <c77892ba-e5cd-1192-ceba-d49edcb95da8@ramsayjones.plus.com>
On Sun, Jan 15, 2023 at 08:54:59PM +0000, Ramsay Jones wrote:
Show 6 quoted lines
> > - curl_easy_setopt(curl, CURLOPT_PUT, 1); > > + curl_easy_setopt(curl, CURLOPT_UPLOAD, 1); > > My version of this patch had '1L' rather than just '1' - but it > doesn't really matter (and was probably because all the curl > examples did so!).
Yeah, I think it probably ought to be 1L because it's going to a variadic function (and it's been a while, but I think the regular integer promotions make small things into int, but not into long).
So I don't mind fixing it, but I think we'd want it in a separate patch, since it's orthogonal to what's happening here.
-Peff