Re: [PATCH v2] ci: do not die on deprecated-declarations warning

From: Jeff King <peff@peff.net>
Date: Jan 14, 2023, 17:17 UTC
Message-ID: <Y8Ljp7yEWTUd92w8@coredump.intra.peff.net>
In-Reply-To: <xmqq7cxpkpjp.fsf@gitster.g>

On Sat, Jan 14, 2023 at 09:13:14AM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> +# Libraries deprecate symbols while retaining them for a long time to
> +# keep software working with both older and newer versions of them.
> +# Getting warnings does help the developers' awareness, but we cannot
> +# afford to update too aggressively.  E.g. CURLOPT_REDIR_PROTOCOLS_STR
> +# is only available in 7.85.0 that deprecates CURLOPT_REDIR_PROTOCOLS
> +# but we cannot rewrite the uses of the latter with the former until
> +# 7.85.0, which was released in August 2022, becomes ubiquitous.
> +DEVELOPER_CFLAGS += -DCURL_DISABLE_DEPRECATION

This seems like a reasonable middle ground to me.

Though we could perhaps even just add it to the main Makefile, and always pass it. People who aren't using DEVELOPER=1 might be annoyed by the warnings (and might even be using -Werror themselves!).

-Peff