Re: [PATCH v2] avoiding deprecated curl options

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Jan 18, 2023, 01:03 UTC
Message-ID: <bdd4eacb-4883-be16-e0b6-296a27dcd98f@ramsayjones.plus.com>
In-Reply-To: <Y8YP+R/hyNr6sEFA@coredump.intra.peff.net>

On 17/01/2023 03:03, Jeff King wrote:

Show 19 quoted lines

> On Sun, Jan 15, 2023 at 03:09:26PM -0500, Jeff King wrote:
> 
>> So I took a look at just dropping the deprecated bits, and it wasn't
>> _too_ bad. Here's that series. The first two I hope are obviously good.
>> The third one is _ugly_, but at least it punts on the whole "how should
>> we silence this" argument, and it takes us in the direction we'd
>> ultimately want to go.
>>
>>   [1/3]: http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT
>>   [2/3]: http: prefer CURLOPT_SEEKFUNCTION to CURLOPT_IOCTLFUNCTION
>>   [3/3]: http: support CURLOPT_PROTOCOLS_STR
> 
> In the interests of wrapping this up, here's a v2 that:
> 
>   - bumps the required curl version to 7.19.5 in patch 2
> 
>   - aims for slightly better readability in the final code of patch 3,
>     versus minimizing the diff
>

I have a _slight_ preference for your v1 patches, but I don't hate this version either! :)

Tonight, I have compile tested both v1 and v2 patches (both in 'seen') on cygwin and linux. I would like to say I have run the tests as well, but it seems I have disabled all the tests on cygwin (expected) *and* on linux (most unexpected).

ie. I don't have apache installed. (I used to have apache, svn and cvs installed to run the tests, but they just took too long to run and caused *many* test runs to hang and leave server processes all over the place. On cygwin, even with all of those tests skipped, it still takes approx 5.5 hours to run the tests).

I thought I was still running the '*http*' tests on linux, but I seem to have dropped the installation of apache at some point - oops!

I guess I should install apache tomorrow ...

ATB, Ramsay Jones