Re: [PATCH 0/3] rev-list: add support for commits in `--missing`

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2023, 17:09 UTC
Message-ID: <xmqqil7etndo.fsf@gitster.g>
In-Reply-To: <ZSTs3BUVtaI9QIoA@tanuki>

Patrick Steinhardt <ps@pks.im> writes:

> I had already reviewed the patches internally at GitLab, so for what
> it's worth please feel free to add my Reviewed-by.

Great. It seems that 'seen' with this series fails to pass the tests, though.

https://github.com/git/git/actions/runs/6462854176/job/17545104753

Thanks.

Show 21 quoted lines

>
> Patrick
>
>> Karthik Nayak (3):
>>   revision: rename bit to `do_not_die_on_missing_objects`
>>   rev-list: move `show_commit()` to the bottom
>>   rev-list: add commit object support in `--missing` option
>> 
>>  builtin/reflog.c            |  2 +-
>>  builtin/rev-list.c          | 93 +++++++++++++++++++------------------
>>  list-objects.c              |  2 +-
>>  object.h                    |  2 +-
>>  revision.c                  |  9 +++-
>>  revision.h                  | 20 ++++----
>>  t/t6022-rev-list-missing.sh | 74 +++++++++++++++++++++++++++++
>>  7 files changed, 145 insertions(+), 57 deletions(-)
>>  create mode 100755 t/t6022-rev-list-missing.sh
>> 
>> -- 
>> 2.41.0
>>