Re: [PATCH 0/3] rev-list: add support for commits in `--missing`

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2023, 16:26 UTC
Message-ID: <xmqqa5snhkmt.fsf@gitster.g>
In-Reply-To: <CAOLa=ZQxNX4oGtqrgLyKenC_D8M=9q0sFJVmo4fyjSPtgw315Q@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> ... To ensure that the feature should
> work with corrupt repositories with stale commit-graph, I'm thinking of
> disabling the commit-graph whenever the `--missing` option is used.

Just to avoid giving anybody a wrong guideline, for most of the other features, we should assume that the commit-graph accurately represents the reality in the object database and take advantage of it, leaving it to "git fsck" to ensure that the commit-graph is healthy.

But "rev-list --missing", especially when used with actions other than allow-promisor or allow-any, is a feature that is only useful when one wants to really notice objects that are available in the object store, and it would be a bug for it to pretend as if objects the commit-graph has heard of exists without checking.