Re: [PATCH v3 3/3] rev-list: add commit object support in `--missing` option

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2023, 17:45 UTC
Message-ID: <xmqqh6mlqjb8.fsf@gitster.g>
In-Reply-To: <CAOLa=ZT6qEsVfNETYua=RjjepDsXFj8uSdphS2LR1gGK1_sGFg@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 7 quoted lines

> Was trying to use bit number 12, which coincides METAINFO_SHOWN in
> builtin/blame.c.
> From skimming over the code, METAINFO_SHOWN is used only within
> blame.c and there
> should not be collisions here since blame.c doesn't set the
> do_not_die_on_missing_objects bit
> either.

Thanks for researching. It sounds like it may be a better bit to steal than the one used by the commit-graph, as long as there is no reason to expect that blame may want to work in a corrupt repository with missing objects, but when it happens, we may regret the decision we are making here.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.