Re: [PATCH v5 2/5] t: move reftable/tree_test.c to the unit testing framework

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 22, 2024, 17:52 UTC
Message-ID: <xmqqikwxco1c.fsf@gitster.g>
In-Reply-To: <20240722061836.4176-3-chandrapratap3519@gmail.com>

Chandra Pratap <chandrapratap3519@gmail.com> writes:

Show 16 quoted lines

> reftable/tree_test.c exercises the functions defined in
> reftable/tree.{c, h}. Migrate reftable/tree_test.c to the unit
> testing framework. Migration involves refactoring the tests to use
> the unit testing framework instead of reftable's test framework and
> renaming the tests to align with unit-tests' standards.
>
> Also add a comment to help understand the test routine.
>
> Note that this commit mostly moves the test from reftable/ to
> t/unit-tests/ and most of the refactoring is performed by the
> trailing commits.
>
> Mentored-by: Patrick Steinhardt <ps@pks.im>
> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
> ---

Looking good.

"git show -M30" matches the moved file up correctly and makes it easy to see that there is no serious changes snuck in (please do not take this as a suggestion to run format-patch with -M30---I am just saying that it was a good way to give an extra validation).

Thanks.