git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/5] t: move reftable/tree_test.c to the unit testing framework

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2024, 17:56 UTC
Message-ID
<xmqq8qxtcnu2.fsf@gitster.g>
In-Reply-To
<xmqqcyn5co04.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> Chandra Pratap <chandrapratap3519@gmail.com> writes:
>
>> +	/* pseudo-randomly insert the pointers for elements between
>> +	 * values[1] and values[10] (included) in the tree.
>> +	 */
>
> Style?
diff --git a/t/unit-tests/t-reftable-tree.c b/t/unit-tests/t-reftable-tree.c
index d7d530f2f7..e7d774d774 100644
--- a/t/unit-tests/t-reftable-tree.c
+++ b/t/unit-tests/t-reftable-tree.c
@@ -32,8 +32,9 @@ static void t_tree_search(void)
 	struct tree_node *nodes[11] = { 0 };
 	size_t i = 1;
 
-	/* pseudo-randomly insert the pointers for elements between
-	 * values[1] and values[10] (included) in the tree.
+	/*
+	 * Pseudo-randomly insert the pointers for elements between
+	 * values[1] and values[10] (inclusive) in the tree.
 	 */
 	do {
 		nodes[i] = tree_search(&values[i], &root, &t_compare, 1);
-- 
2.46.0-rc1-48-g0900f1888e
Previous: Junio C HamanoNext: Chandra Pratap
Message 44 of 66 in “t: port reftable/tree_test.c to the unit testing framework”
  1. Chandra PratapJun 10, 2024
  2. 1/4 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Jun 10, 2024
  3. 2/4 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jun 10, 2024
  4. 3/4 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Jun 10, 2024
  5. Patrick SteinhardtJun 10, 2024
  6. Chandra PratapJun 11, 2024
  7. 4/4 t-reftable-tree: add test for non-existent keyChandra Pratap, Jun 10, 2024
  8. [GSoC][PATCH v2 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jun 12, 2024
  9. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Jun 12, 2024
  10. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jun 12, 2024
  11. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Jun 12, 2024
  12. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Jun 12, 2024
  13. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Jun 12, 2024
  14. Patrick SteinhardtJun 12, 2024
  15. Chandra PratapJun 12, 2024
  16. [GSoC][PATCH v3 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jun 12, 2024
  17. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Jun 12, 2024
  18. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jun 12, 2024
  19. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Jun 12, 2024
  20. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Jun 12, 2024
  21. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Jun 12, 2024
  22. [GSoC][PATCH v4 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jul 16, 2024
  23. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Jul 16, 2024
  24. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jul 16, 2024
  25. Karthik NayakJul 17, 2024
  26. Chandra PratapJul 17, 2024
  27. Karthik NayakJul 18, 2024
  28. Karthik NayakJul 17, 2024
  29. Chandra PratapJul 17, 2024
  30. Justin ToblerJul 17, 2024
  31. Chandra PratapJul 18, 2024
  32. Karthik NayakJul 18, 2024
  33. Chandra PratapJul 18, 2024
  34. Justin ToblerJul 18, 2024
  35. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Jul 16, 2024
  36. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Jul 16, 2024
  37. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Jul 16, 2024
  38. Junio C HamanoJul 16, 2024
  39. [GSoC][PATCH v5 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jul 22, 2024
  40. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Jul 22, 2024
  41. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Jul 22, 2024
  42. Junio C HamanoJul 22, 2024
  43. Junio C HamanoJul 22, 2024
  44. Junio C HamanoJul 22, 2024
  45. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Jul 22, 2024
  46. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Jul 22, 2024
  47. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Jul 22, 2024
  48. Chandra PratapAug 1, 2024
  49. Patrick SteinhardtAug 1, 2024
  50. [GSoC][PATCH v6 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Aug 2, 2024
  51. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Aug 2, 2024
  52. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Aug 2, 2024
  53. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Aug 2, 2024
  54. Junio C HamanoAug 2, 2024
  55. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Aug 2, 2024
  56. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Aug 2, 2024
  57. [GSoC][PATCH v7 0/5] t: port reftable/tree_test.c to the unit testing frameworkChandra Pratap, Aug 4, 2024
  58. 1/5 reftable: remove unnecessary curly braces in reftable/tree.cChandra Pratap, Aug 4, 2024
  59. 2/5 t: move reftable/tree_test.c to the unit testing frameworkChandra Pratap, Aug 4, 2024
  60. 3/5 t-reftable-tree: split test_tree() into two sub-test functionsChandra Pratap, Aug 4, 2024
  61. 4/5 t-reftable-tree: add test for non-existent keyChandra Pratap, Aug 4, 2024
  62. 5/5 t-reftable-tree: improve the test for infix_walk()Chandra Pratap, Aug 4, 2024
  63. Patrick SteinhardtAug 5, 2024
  64. Junio C HamanoAug 5, 2024
  65. Patrick SteinhardtAug 6, 2024
  66. Junio C HamanoAug 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.