Re: [GSoC][PATCH v7 0/5] t: port reftable/tree_test.c to the unit testing framework
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 5, 2024, 11:04 UTC
- Message-ID
- <ZrCx0NWRbFOOReki@tanuki>
- In-Reply-To
- <20240804141105.4268-1-chandrapratap3519@gmail.com>
On Sun, Aug 04, 2024 at 07:36:44PM +0530, Chandra Pratap wrote:
Show 18 quoted lines
> The reftable library comes with self tests, which are exercised > as part of the usual end-to-end tests and are designed to > observe the end-user visible effects of Git commands. What it > exercises, however, is a better match for the unit-testing > framework, merged at 8bf6fbd0 (Merge branch 'js/doc-unit-tests', > 2023-12-09), which is designed to observe how low level > implementation details, at the level of sequences of individual > function calls, behave. > > Hence, port reftable/tree_test.c to the unit testing framework and > improve upon the ported test. The first patch in the series is > preparatory cleanup, the second patch moves the test to the unit > testing framework, and the rest of the patches improve upon the > ported test. > > Mentored-by: Patrick Steinhardt <ps@pks.im> > Mentored-by: Christian Couder <chriscool@tuxfamily.org> > Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Only a single change compared to v6, addressing the only feedback on that version. So this looks good to me, thanks!
Patrick