git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC PATCH v2 2/2] builtin/prune: stop depending on 'the_repository'

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 1, 2025, 16:42 UTC
Message-ID
<xmqqikkbkglx.fsf@gitster.g>
In-Reply-To
<aGPcKgR0G72JRSlM@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 12 quoted lines
> On Mon, Jun 30, 2025 at 10:11:05PM +0530, Ayush Chandekar wrote:
>> @@ -173,20 +171,19 @@ int cmd_prune(int argc,
>>  	expire = TIME_MAX;
>>  	save_commit_buffer = 0;
>>  	disable_replace_refs();
>> -	repo_init_revisions(the_repository, &revs, prefix);
>> +	repo_init_revisions(repo, &revs, prefix);
>
> Does this work correctly when running outside of a repository? In
> general `cmd_prune()` is not executed and would instead die as it is
> declared as `RUN_SETUP`, without the `_GENTLY` suffix. But when the user
> asks for help we may still execute the function with a NULL pointer.

Good eyes. "git prune -h" would safely exit in parse_options() in such a case, but this part happens before the parse_options() call.

Previous: Patrick SteinhardtNext: Ayush Chandekar
Message 16 of 29 in “builtin/prune: remove dependency on global variables and 'the_repository'”
  1. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jun 8, 2025
  2. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jun 8, 2025
  3. shejialuoJun 28, 2025
  4. Ayush ChandekarJun 28, 2025
  5. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jun 8, 2025
  6. shejialuoJun 28, 2025
  7. Ayush ChandekarJun 28, 2025
  8. Ayush ChandekarJun 25, 2025
  9. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jun 30, 2025
  10. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jun 30, 2025
  11. Patrick SteinhardtJul 1, 2025
  12. Ayush ChandekarJul 1, 2025
  13. Patrick SteinhardtJul 2, 2025
  14. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jun 30, 2025
  15. Patrick SteinhardtJul 1, 2025
  16. Junio C HamanoJul 1, 2025
  17. Ayush ChandekarJul 1, 2025
  18. Usman AkinyemiJul 1, 2025
  19. Ayush ChandekarJul 1, 2025
  20. Patrick SteinhardtJul 2, 2025
  21. Usman AkinyemiJul 2, 2025
  22. Ben KnobleJul 2, 2025
  23. Junio C HamanoJul 2, 2025
  24. Ayush ChandekarJul 2, 2025
  25. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jul 4, 2025
  26. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jul 4, 2025
  27. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jul 4, 2025
  28. Patrick SteinhardtJul 7, 2025
  29. Ayush ChandekarJul 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.