git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC PATCH 2/2] builtin/prune: stop depending on 'the_repository'

From
shejialuo <shejialuo@gmail.com>
Date
Jun 28, 2025, 07:33 UTC
Message-ID
<aF-asGE-cX8IpAae@ArchLinux>
In-Reply-To
<9b274efd7dfde90990ace66bfbe5f7e3b6ce30d1.1749343601.git.ayu.chandekar@gmail.com>
On Sun, Jun 08, 2025 at 06:36:35AM +0530, Ayush Chandekar wrote:
[snip]
Show 7 quoted lines
> @@ -99,7 +98,7 @@ static int prune_object(const struct object_id *oid, const char *fullpath,
>  	if (st.st_mtime > expire)
>  		return 0;
>  	if (show_only || verbose) {
> -		enum object_type type = oid_object_info(the_repository, oid,
> +		enum object_type type = oid_object_info(revs->repo, oid,
>  							NULL);

Could we simply make `NULL` in the same line by the way? The readability would be better.

Show 33 quoted lines
>  		printf("%s %s\n", oid_to_hex(oid),
>  		       (type > 0) ? type_name(type) : "unknown");
> @@ -154,7 +153,7 @@ static void remove_temporary_files(const char *path)
>  int cmd_prune(int argc,
>  	      const char **argv,
>  	      const char *prefix,
> -	      struct repository *repo UNUSED)
> +	      struct repository *repo)
>  {
>  	struct rev_info revs;
>  	int exclude_promisor_objects = 0;
> @@ -173,19 +172,19 @@ int cmd_prune(int argc,
>  	expire = TIME_MAX;
>  	save_commit_buffer = 0;
>  	disable_replace_refs();
> -	repo_init_revisions(the_repository, &revs, prefix);
> +	repo_init_revisions(repo, &revs, prefix);
>  
>  	argc = parse_options(argc, argv, prefix, options, prune_usage, 0);
>  
> -	if (the_repository->repository_format_precious_objects)
> +	if (repo->repository_format_precious_objects)
>  		die(_("cannot prune in a precious-objects repo"));
>  
>  	while (argc--) {
>  		struct object_id oid;
>  		const char *name = *argv++;
>  
> -		if (!repo_get_oid(the_repository, name, &oid)) {
> -			struct object *object = parse_object_or_die(the_repository, &oid,
> +		if (!repo_get_oid(repo, name, &oid)) {
> +			struct object *object = parse_object_or_die(repo, &oid,
>  								    name);

Same, could we just make `name` in the same line. There is no need for the newline right now as we change "the_repository" to "repo" which would reduce some columns.

Thanks, Jialuo

Previous: Ayush ChandekarNext: Ayush Chandekar
Message 6 of 29 in “builtin/prune: remove dependency on global variables and 'the_repository'”
  1. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jun 8, 2025
  2. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jun 8, 2025
  3. shejialuoJun 28, 2025
  4. Ayush ChandekarJun 28, 2025
  5. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jun 8, 2025
  6. shejialuoJun 28, 2025
  7. Ayush ChandekarJun 28, 2025
  8. Ayush ChandekarJun 25, 2025
  9. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jun 30, 2025
  10. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jun 30, 2025
  11. Patrick SteinhardtJul 1, 2025
  12. Ayush ChandekarJul 1, 2025
  13. Patrick SteinhardtJul 2, 2025
  14. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jun 30, 2025
  15. Patrick SteinhardtJul 1, 2025
  16. Junio C HamanoJul 1, 2025
  17. Ayush ChandekarJul 1, 2025
  18. Usman AkinyemiJul 1, 2025
  19. Ayush ChandekarJul 1, 2025
  20. Patrick SteinhardtJul 2, 2025
  21. Usman AkinyemiJul 2, 2025
  22. Ben KnobleJul 2, 2025
  23. Junio C HamanoJul 2, 2025
  24. Ayush ChandekarJul 2, 2025
  25. 0/2 builtin/prune: remove dependency on global variables and 'the_repository'Ayush Chandekar, Jul 4, 2025
  26. 1/2 repository: move 'repository_format_precious_objects' to repo scopeAyush Chandekar, Jul 4, 2025
  27. 2/2 builtin/prune: stop depending on 'the_repository'Ayush Chandekar, Jul 4, 2025
  28. Patrick SteinhardtJul 7, 2025
  29. Ayush ChandekarJul 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.