Re: [GSOC PATCH 1/2] repository: move 'repository_format_precious_objects' to repo scope

From: shejialuo <shejialuo@gmail.com>
Date: Jun 28, 2025, 07:26 UTC
Message-ID: <aF-ZLbf8rBHrHOXb@ArchLinux>
In-Reply-To: <6ffb071295272a1d5311f52d8d2015d0aec7e71f.1749343601.git.ayu.chandekar@gmail.com>

On Sun, Jun 08, 2025 at 06:36:34AM +0530, Ayush Chandekar wrote:

> The 'extensions.preciousObjects' settings when set true, prevents

Should "settings" be "setting"?

Show 10 quoted lines

> operations that might drop objects from the object storage.
> This setting is populated in the global variable
> 'repository_format_precious_objects'.
> Move this global variable to repo scope by adding it to 'struct
> repository' and also refactor all the occurences accordingly.
> 
> This change is part of an ongoing effort to eliminate global variables,
> improve modularity and help libify the codebase.
> 
> Signed-off-by: Ayush Chandekar <ayu.chandekar@gmail.com>

Maybe you should add the following things before "Signed-off-by":

    Mentored-by: ...
    Mentored-by: ...

Thanks, Jialuo