Re: [PATCH v3 15/17] odb/source-packed: stub out remaining functions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 18, 2026, 17:59 UTC
- Message-ID
- <xmqqik7frapn.fsf@gitster.g>
- In-Reply-To
- <20260617-pks-odb-source-packed-v3-15-b5c7583cd795@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Just FYI (i.e. nothing wrong in this patch)
> +static int odb_source_packed_write_object(struct odb_source *source UNUSED, > + const void *buf UNUSED, > + unsigned long len UNUSED,
The type of this parameter will become size_t via another topic in flight; I prepared an evil merge to address it (otherwise winbuild would barf, as expected).
-- >8 -- Author: Junio C Hamano <gitster@pobox.com> Date: Thu Jun 18 10:49:10 2026 -0700
merge-fix po/hash-object-size-t vs ps/odb-source-packed
diff --git a/odb/source-packed.c b/odb/source-packed.c index 42c28fba0e..decc81aa52 100644 --- a/odb/source-packed.c +++ b/odb/source-packed.c @@ -503,7 +503,7 @@ static int odb_source_packed_freshen_object(struct odb_source *source, static int odb_source_packed_write_object(struct odb_source *source UNUSED, const void *buf UNUSED, - unsigned long len UNUSED, + size_t len UNUSED, enum object_type type UNUSED, struct object_id *oid UNUSED, struct object_id *compat_oid UNUSED,