Re: [PATCH v2 07/17] odb/source-packed: wire up `reprepare()` callback
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jun 17, 2026, 07:26 UTC
- Message-ID
- <ajJMLM2T34Gf80ft@pks.im>
- In-Reply-To
- <ajHDm_pG3Ckca4mp@denethor>
On Tue, Jun 16, 2026 at 04:53:38PM -0500, Justin Tobler wrote:
Show 11 quoted lines
> On 26/06/09 10:51AM, Patrick Steinhardt wrote: > > Move the logic to prepare and reprepare the "packed" source into > > "odb/source-packed.c" and wire it up as the `reprepare()` callback. > > > > Note that "preparing" a source is not yet generic. Eventually, it would > > probably make sense to turn the existing `reprepare()` callback into a > > `prepare()` callback with an optional flag to force re-preparing. But > > this step will be handled in a separate patch series. > > I do find the prepare vs reprepare semantics a bit confusing. The > mentioned change above would be nice to see in the future. :)
It is confusing, agreed. I have already written the patch series that converts this.
Patrick