Re: [PATCH 00/16] odb: make packed object source a proper `struct odb_source`
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Jun 8, 2026, 16:15 UTC
- Message-ID
- <CAOLa=ZT9PLFeVpyKph=jQOz_BHXhYgKO=-3SV_VP6p4oXLxZpg@mail.gmail.com>
- In-Reply-To
- <20260604-pks-odb-source-packed-v1-0-2e7ab31b4b5c@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 22 quoted lines
> Hi, > > this patch series converts the "packed" source into a proper `struct > odb_source`. It's thus the equivalent to [1], which did the same thing > for the "loose" source. > > This series here is unfortunately a bit bigger, mostly because I'm also > renaming `struct packfile_store` to `struct odb_source_packed`. Back > when I introduced the packfile store I didn't yet have the full vision > of how the final layout will look like, so I didn't have the foresight > yet to call it `struct odb_source_packed`. But now that the layout has > materialized I think it's sensible to adjust its naming to match all the > other sources that we have. > > Also: I don't have anything else in the pipeline anymore that moves > around large pieces of our code in the vicinity of the object database. > So after this series got merged, subsequent changes should be of a more > incremental nature. > > This series is built on top of 9ac3f193c0 (The 11th batch, 2026-06-02) > with ps/odb-source-loose at ef4778bcba (odb/source-loose: drop pointer > to the "files" source, 2026-06-01) merged into it.
This was a good read. The commits towards the end are mostly simple code movements. Overall the series looks to be in good shape.
[snip]