Re: [PATCH v2 04/17] odb/source-packed: store pointer to "files" instead of generic source
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Jun 16, 2026, 21:28 UTC
- Message-ID
- <ajG_gC73ch923EkI@denethor>
- In-Reply-To
- <ajG69JZHx_u2mt7q@denethor>
On 26/06/16 04:14PM, Justin Tobler wrote:
Show 10 quoted lines
> On 26/06/09 10:50AM, Patrick Steinhardt wrote: > > The `struct odb_source_packed` holds a pointer to its owning parent > > source. The way that Git is currently structured, this parent is always > > the "files" source. In subsequent commits we're going to detangle that > > so that the "packed" source doesn't have any owning parent source at > > all, which makes it usable as a completely standalone source. > > Out of curiousity, `struct odb_source_loose` also stores a similar to > pointer to its owning parent. Is the plan to also eventually do the same > there?
Ok, I think I got myself mixed up. IIUC the `struct odb_source` pointer currently stored in `struct odb_source_loose` is not to the parent source, but to its "base". And the eventual goal here is to move towards that same direction which makes sense.
-Justin