Re: More builtin git-am issues..

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2015, 00:54 UTC
Message-ID: <xmqqh9n9ele4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFw2bnhSQYk4FaHfp4ED0Y611NWyQs05TMQtFj=2As1=nA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 5 quoted lines

> So I think that logic should basically be extended to saying
>
>  - if any line in the last chunk has a "Signed-off-by:", set a flag.
>
>  - at the end of the loop, if that flag wasn't set, return 0.

I am reluctant to special case S-o-b: too much, even though this is about "am -s" and by definition S-o-b: is special, as that is what we are adding after all.

How about a bit looser rule like this?

    A block of text at the end of the message, each and every
    line in which must match "^[^: 	]+:[      ]" (that is,
    a "keyword" that does not contain a whitespace nor a colon,
    followed by a colon and whitespace, and arbitrary value thru
    the end of line) is a signature block.