Re: More builtin git-am issues..
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Sep 5, 2015, 07:30 UTC
- Message-ID
- <55EA9A13.2050108@kdbg.org>
- In-Reply-To
- <xmqqh9n9ele4.fsf@gitster.mtv.corp.google.com>
Am 05.09.2015 um 02:54 schrieb Junio C Hamano:
Show 19 quoted lines
> Linus Torvalds <torvalds@linux-foundation.org> writes: > >> So I think that logic should basically be extended to saying >> >> - if any line in the last chunk has a "Signed-off-by:", set a flag. >> >> - at the end of the loop, if that flag wasn't set, return 0. > > I am reluctant to special case S-o-b: too much, even though this is > about "am -s" and by definition S-o-b: is special, as that is what > we are adding after all. > > How about a bit looser rule like this? > > A block of text at the end of the message, each and every > line in which must match "^[^: ]+:[ ]" (that is, > a "keyword" that does not contain a whitespace nor a colon, > followed by a colon and whitespace, and arbitrary value thru > the end of line) is a signature block.
Why do we need a new rule? The old git-am had a logic that pleased everyone, and it must have been implemented somewhere. Shouldn't it be sufficient to just re-implement or re-use that logic?
-- Hannes