Re: More builtin git-am issues..

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2015, 01:23 UTC
Message-ID: <xmqq613pek1b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+55aFw-PObyj2boqpeA9DDcKeAuCGouT7Qd2Zw02+sxvd2CgA@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 8 quoted lines

> The thing is, and that was what the report was all about, not every
> line _is_ of that format. We have commetns from the sign-off people.
> Things like this:
>
>     Signed-off-by: Noam Camus <noamc@ezchip.com>
>     Acked-by: Vineet Gupta <vgupta@synopsys.com>
>     [ Also removed pointless cast from "void *".  - Linus ]
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

OK, I didn't know that was acceptable in the kernel community to have random comments like that inside the block. Can these comments span multiple paragraphs? What I am wondering is what you want to see in a case like this:

     Signed-off-by: Noam Camus <noamc@ezchip.com>
     Acked-by: Vineet Gupta <vgupta@synopsys.com>
     [ Also removed pointless cast from "void *". - Linus]
     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
     [ Ahh, we have to tell at least these people

      - stakeholder class 1
      - staeholder class 2
     ]
     Cc: foo
     Cc: bar