Re: [PATCH v2 3/3] fetch: reduce duplicate in ref update status lines

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2016, 17:04 UTC
Message-ID: <xmqqh9dap5jk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <575199E7.7000503@xiplink.com>

Marc Branchaud <marcnarc@xiplink.com> writes:

Show 8 quoted lines

> What if we detect when the full line exceeds the terminal width, and
> insert a newline after the remote ref and indent the ->  to the same
> offset as its surrounding lines, like this:
>
>  * [new branch]      2nd-index -> pclouds/2nd-index
>  * [new branch]      some-kind-of-long-ref-name
>                                -> pclouds/some-kind-of-long-ref-name
>  * [new branch]      3nd-index -> pclouds/3nd-index

I am OK with this format (not in the sense that I like it better than what the patch produces, but in the sense that I do not have strong preference either way). It may be hard to come up with a good heuristics to decide where on the display width "->" should come, though.

Show 7 quoted lines

>> +When `from` and `to` share a common suffix, the line could be
>> +displayed in the form:
>> +
>> +-------------------------------
>> + <flag> <summary> {<from> -> <to>}<suffix> (<reason>)
>
> If we go with this format, we'll need to document <suffix>.

The sentence above calls it "a common suffix", so instead of saying <suffix> we can say <common-suffix> perhaps? Or did you mean something more than that?