Re: [PATCH v2 3/3] fetch: reduce duplicate in ref update status lines

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 3, 2016, 23:52 UTC
Message-ID: <CACsJy8DV5aqsxM9+QZ+5d2fMLYF4foBnAxmyiYHOLtqzvS3QGQ@mail.gmail.com>
In-Reply-To: <20160603170621.GA3858@sigill.intra.peff.net>

On Sat, Jun 4, 2016 at 12:06 AM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

> On Fri, Jun 03, 2016 at 06:08:43PM +0700, Nguyễn Thái Ngọc Duy wrote:
>
>> When there are lots of ref updates, each has different name length, this
>> will make it easier to look because the variable part is at the end.
>
> Is it worth handling more complicated cases, where there is a similar
> "middle", but different beginning?
>
> One of my common refspecs is:
>
>   +refs/pull/*/head:refs/remotes/pull/*
>
> That still shows as:
>
>   refs/pull/123/head -> pull/123
>
> but could be:
>
>   {refs -> }/pull/123{head -> }
>
> I actually think that _isn't_ an improvement, but I wonder if there is a
> format that would be.

A placeholder can still keep the variable part at the end, e.g. "refs/$/head -> pull/123"

-- 
Duy