Re: [PATCH v2 0/3] Better ref summary alignment in "git fetch"

From: Jeff King <peff@peff.net>
Date: Jun 3, 2016, 17:00 UTC
Message-ID: <20160603170058.GB1733@sigill.intra.peff.net>
In-Reply-To: <20160603110843.15434-1-pclouds@gmail.com>

On Fri, Jun 03, 2016 at 06:08:40PM +0700, Nguyễn Thái Ngọc Duy wrote:

Show 5 quoted lines

> v2 reformats "abc/common -> def/common" to "{abc -> def}/common"
> instead and fall back to "a -> b" when they have nothing in commmon
> (e.g. "HEAD -> FETCH_HEAD"). We could add an option if a user wants to
> stick with "a -> b" (and we could do some alignment there as well) but
> it's not part of this series.

I tried this on one of my nastiest long-branch-heavy repos. It really does look better than the status quo. I think it's nicer than the stair-stepping proposal in that it does get everything aligned perfectly, and reduces wasted data that spills off the side of my terminal.

I do somehow find the:

  { -> origin}/whatever

a little off-putting, I think because the "from" side is empty, and therefore you get this weird mix of punctuation: "{ ->". I wonder if there's another syntactic shorthand we could apply in that case (especially since it will easily be the most common), but I couldn't think of one.

> It's a shame that the flag '-' in these ref update lines is not the
> same in fetch and push (see 1/3). Because git-fetch does not support
> --porcelain option, maybe it's not too late to change its meaning...

I'd agree with that final "maybe". :)

-Peff