git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] deprecate git stash save

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 23, 2017, 06:26 UTC
Message-ID
<xmqqh8uqbcsc.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171023051850.vil3p5pmu3jb2a5y@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Mon, Oct 23, 2017 at 10:19:38AM +0900, Junio C Hamano wrote:
>
>> > -	This option is deprecated in favour of 'git stash push'.
>> > +	This option is deprecated in favour of 'git stash push'.  It
>> > +	differs from "stash push" in that it cannot take pathspecs,
>> > +	and any non-option arguments form the message.
>> 
>> Every time I saw this line, I misread s/form/from/ and got
>> confused.
>
> We could reverse the order:
>
>    ...and the message is taken from any non-option arguments.

Yeah, that makes it slightly less confusing. Or "any non-option arguments become the message", perhaps? I dunno.

Let's queue the version as posted; perhaps somebody new comes and says it is confusing in three months, at which time we may be able to come up with a better phrasing with a fresh mind ;-)

Previous: Jeff KingNext: Robert P. J. Day
Message 26 of 30 in “[RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)”
  1. Thomas GummererOct 5, 2017
  2. 2/1 mention git stash push first in the man pageThomas Gummerer, Oct 5, 2017
  3. Jeff KingOct 17, 2017
  4. Thomas GummererOct 17, 2017
  5. Jeff KingOct 17, 2017
  6. Thomas GummererOct 19, 2017
  7. Robert P. J. DayOct 20, 2017
  8. Jeff KingOct 21, 2017
  9. Robert P. J. DayOct 21, 2017
  10. Junio C HamanoOct 12, 2017
  11. Junio C HamanoOct 12, 2017
  12. Thomas GummererOct 16, 2017
  13. Jeff KingOct 17, 2017
  14. Thomas GummererOct 17, 2017
  15. 1/2 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 19, 2017
  16. 2/2 mark git stash push deprecated in the man pageThomas Gummerer, Oct 19, 2017
  17. Jeff KingOct 21, 2017
  18. Thomas GummererOct 22, 2017
  19. 0/3 deprecate git stash saveThomas Gummerer, Oct 22, 2017
  20. 1/3 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 22, 2017
  21. 2/3 mark git stash push deprecated in the man pageThomas Gummerer, Oct 22, 2017
  22. 3/3 stash: remove now superfluos help for "stash push"Thomas Gummerer, Oct 22, 2017
  23. Jeff KingOct 23, 2017
  24. Junio C HamanoOct 23, 2017
  25. Jeff KingOct 23, 2017
  26. Junio C HamanoOct 23, 2017
  27. Robert P. J. DayOct 23, 2017
  28. Junio C HamanoOct 23, 2017
  29. Jeff KingOct 21, 2017
  30. Thomas GummererOct 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.