git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/1] mention git stash push first in the man page

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Oct 17, 2017, 21:45 UTC
Message-ID
<20171017214515.GG15399@hank>
In-Reply-To
<20171017041405.eavuutzgzgs4ppk2@sigill.intra.peff.net>
On 10/17, Jeff King wrote:
Show 11 quoted lines
> On Thu, Oct 05, 2017 at 09:10:29PM +0100, Thomas Gummerer wrote:
> 
> > Because 'stash push' and 'stash save' are so closely related they share one
> > section in the man page.  Currently 'stash save' comes first, as that
> > was the command that people were historically using.  However this makes
> > the newer, more feature rich git stash push very easy to overlook.
> > Change the order to give the newer interface for creating a stash the
> > more prominent position.
> 
> Seems reasonable, though if we are deprecating "save" should we demote
> it from being in the synopsis entirely?

I saw that as a next step, with the "official" deprecation of "save". I thought we might want to advertise "push" a bit more before actually officially deprecating "save" and sending the deprecation notice out in the release notes.

OTOH, dropping it from the synopsis in the man page probably wouldn't cause much issue, as "push" directly replaces it, and is easily visible. Not sure how slow we want to take the deprecation?

> -Peff
Previous: Jeff KingNext: Jeff King
Message 4 of 30 in “[RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)”
  1. Thomas GummererOct 5, 2017
  2. 2/1 mention git stash push first in the man pageThomas Gummerer, Oct 5, 2017
  3. Jeff KingOct 17, 2017
  4. Thomas GummererOct 17, 2017
  5. Jeff KingOct 17, 2017
  6. Thomas GummererOct 19, 2017
  7. Robert P. J. DayOct 20, 2017
  8. Jeff KingOct 21, 2017
  9. Robert P. J. DayOct 21, 2017
  10. Junio C HamanoOct 12, 2017
  11. Junio C HamanoOct 12, 2017
  12. Thomas GummererOct 16, 2017
  13. Jeff KingOct 17, 2017
  14. Thomas GummererOct 17, 2017
  15. 1/2 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 19, 2017
  16. 2/2 mark git stash push deprecated in the man pageThomas Gummerer, Oct 19, 2017
  17. Jeff KingOct 21, 2017
  18. Thomas GummererOct 22, 2017
  19. 0/3 deprecate git stash saveThomas Gummerer, Oct 22, 2017
  20. 1/3 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 22, 2017
  21. 2/3 mark git stash push deprecated in the man pageThomas Gummerer, Oct 22, 2017
  22. 3/3 stash: remove now superfluos help for "stash push"Thomas Gummerer, Oct 22, 2017
  23. Jeff KingOct 23, 2017
  24. Junio C HamanoOct 23, 2017
  25. Jeff KingOct 23, 2017
  26. Junio C HamanoOct 23, 2017
  27. Robert P. J. DayOct 23, 2017
  28. Junio C HamanoOct 23, 2017
  29. Jeff KingOct 21, 2017
  30. Thomas GummererOct 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.