git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] deprecate git stash save?

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Oct 16, 2017, 18:19 UTC
Message-ID
<20171016181947.GE15399@hank>
In-Reply-To
<xmqqy3ogy5wf.fsf@gitster.mtv.corp.google.com>
On 10/12, Junio C Hamano wrote:
Show 19 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Thomas Gummerer <t.gummerer@gmail.com> writes:
> >
> >> git stash push is the newer interface for creating a stash.  While we
> >> are still keeping git stash save around for the time being, it's better
> >> to point new users of git stash to the more modern (and more feature
> >> rich) interface, instead of teaching them the older version that we
> >> might want to phase out in the future.
> >
> > With devil's advocate hat on, because the primary point of "stash"
> > being "clear the desk quickly", I do not necessarily agree that
> > "more feature rich" is a plus and something we should nudge newbies
> > towards.
> 
> I do not particulary view "feature richness" is the primary benefit
> of 'push' that makes it shine.  'save' has a quirk in the command
> line option syntax, but 'push' corrects it, and that is why we want
> to move users towards the latter.

I agree it's not the primary benefit (hence why it's in braces :)), but I at least some users will eventually want the features 'git stash push' has to offer, and it's better if they don't have to re-train their fingers at that point.

But yeah, fixing the quirky command line interface is definitely the stronger reason for deprecating it.

> IOW, I do not object to the agenda; it is just I found the
> justification used to push the agenda forward was flawed.

I'm happy as long as we agree on the agenda here. Any opinions about the patches themselves? Would you prefer me to resend with an updated description?

> Thanks.
Previous: Junio C HamanoNext: Jeff King
Message 12 of 30 in “[RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)”
  1. Thomas GummererOct 5, 2017
  2. 2/1 mention git stash push first in the man pageThomas Gummerer, Oct 5, 2017
  3. Jeff KingOct 17, 2017
  4. Thomas GummererOct 17, 2017
  5. Jeff KingOct 17, 2017
  6. Thomas GummererOct 19, 2017
  7. Robert P. J. DayOct 20, 2017
  8. Jeff KingOct 21, 2017
  9. Robert P. J. DayOct 21, 2017
  10. Junio C HamanoOct 12, 2017
  11. Junio C HamanoOct 12, 2017
  12. Thomas GummererOct 16, 2017
  13. Jeff KingOct 17, 2017
  14. Thomas GummererOct 17, 2017
  15. 1/2 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 19, 2017
  16. 2/2 mark git stash push deprecated in the man pageThomas Gummerer, Oct 19, 2017
  17. Jeff KingOct 21, 2017
  18. Thomas GummererOct 22, 2017
  19. 0/3 deprecate git stash saveThomas Gummerer, Oct 22, 2017
  20. 1/3 replace git stash save with git stash push in the documentationThomas Gummerer, Oct 22, 2017
  21. 2/3 mark git stash push deprecated in the man pageThomas Gummerer, Oct 22, 2017
  22. 3/3 stash: remove now superfluos help for "stash push"Thomas Gummerer, Oct 22, 2017
  23. Jeff KingOct 23, 2017
  24. Junio C HamanoOct 23, 2017
  25. Jeff KingOct 23, 2017
  26. Junio C HamanoOct 23, 2017
  27. Robert P. J. DayOct 23, 2017
  28. Junio C HamanoOct 23, 2017
  29. Jeff KingOct 21, 2017
  30. Thomas GummererOct 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.