git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] status: add an empty line when there is no hint

From
Junio C Hamano <gitster@pobox.com>
Date
May 13, 2019, 05:51 UTC
Message-ID
<xmqqh89ydhqu.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CAKO26Mtn+KDnkHWsKf8mAyTmeaCYK0gjdNad5bxJe-qxjKs=xw@mail.gmail.com>
林自均 <johnlinp@gmail.com> writes:
> Hi Junio,
>> ...
> Could you please give me some advice on my patch? Thank you.

I tend to agree with what Phillip said in <ae1332b8-a227-e83a-8862-8811b6a81251@gmail.com>.

If the difference between "status" and "commit" bothers you so much, i.e.

    When typing "git status", there is an empty line between the
    "Changes not staged for commit:" block and the list of changed
    files. However, when typing "git commit" with no files added,
    there are no empty lines between them.

it may not be a bad idea to try making them consistent by removing the blank line that is given after the advice messages, perhaps?

Previous: 林自均Next: 林自均
Message 9 of 16 in “status: add an empty line when there is no hint”
  1. status: add an empty line when there is no hintJohn Lin, Apr 30, 2019
  2. Phillip WoodApr 30, 2019
  3. 林自均Apr 30, 2019
  4. brian m. carlsonMay 1, 2019
  5. 林自均May 2, 2019
  6. brian m. carlsonMay 2, 2019
  7. 林自均May 3, 2019
  8. 林自均May 10, 2019
  9. Junio C HamanoMay 13, 2019
  10. 林自均May 14, 2019
  11. brian m. carlsonMay 14, 2019
  12. Junio C HamanoMay 14, 2019
  13. 林自均May 14, 2019
  14. Junio C HamanoMay 15, 2019
  15. 林自均May 15, 2019
  16. 林自均May 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.