Re: [PATCH v2] status: add an empty line when there is no hint

From: 林自均 <johnlinp@gmail.com>
Date: May 10, 2019, 00:56 UTC
Message-ID: <CAKO26Mtn+KDnkHWsKf8mAyTmeaCYK0gjdNad5bxJe-qxjKs=xw@mail.gmail.com>
In-Reply-To: <CAKO26MuisScMPp0SxRo896y7waEgR3HjU3A8+VM73eS0xgU8RQ@mail.gmail.com>

Hi Junio,

林自均 <johnlinp@gmail.com> 於 2019年5月3日 週五 下午12:15寫道：

Show 16 quoted lines

>
> Hi Brian,
>
> brian m. carlson <sandals@crustytoothpaste.net> 於 2019年5月3日 週五 上午7:15寫道：
> >
> > On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote:
> > > Thank you for the support! I'll be very happy if my patch can get into
> > > the code base. Is there any improvement I can make for this patch?
> >
> > The patch seems sane to me. There's less duplicate code than the patch I
> > started writing; the goto conclude seems to avoid most of it.
>
> I see. Let's wait for more comments on my patch. Thank you.
>
> Best,
> John Lin

Could you please give me some advice on my patch? Thank you.

Best, John Lin

Show 5 quoted lines

>
>
> > --
> > brian m. carlson: Houston, Texas, US
> > OpenPGP: https://keybase.io/bk2204