git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] status: add an empty line when there is no hint

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 2, 2019, 23:15 UTC
Message-ID
<20190502231537.GE202237@genre.crustytoothpaste.net>
In-Reply-To
<CAKO26MvXmOMHgqWSoVrmdwyDFyqDrChkMOHq6iuJAX8pvHzZoA@mail.gmail.com>
On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote:
> Thank you for the support! I'll be very happy if my patch can get into
> the code base. Is there any improvement I can make for this patch?

The patch seems sane to me. There's less duplicate code than the patch I started writing; the goto conclude seems to avoid most of it.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: 林自均Next: 林自均
Message 6 of 16 in “status: add an empty line when there is no hint”
  1. status: add an empty line when there is no hintJohn Lin, Apr 30, 2019
  2. Phillip WoodApr 30, 2019
  3. 林自均Apr 30, 2019
  4. brian m. carlsonMay 1, 2019
  5. 林自均May 2, 2019
  6. brian m. carlsonMay 2, 2019
  7. 林自均May 3, 2019
  8. 林自均May 10, 2019
  9. Junio C HamanoMay 13, 2019
  10. 林自均May 14, 2019
  11. brian m. carlsonMay 14, 2019
  12. Junio C HamanoMay 14, 2019
  13. 林自均May 14, 2019
  14. Junio C HamanoMay 15, 2019
  15. 林自均May 15, 2019
  16. 林自均May 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.