Re: [PATCH v2] status: add an empty line when there is no hint

From: 林自均 <johnlinp@gmail.com>
Date: May 14, 2019, 00:30 UTC
Message-ID: <CAKO26MvkD6-ZuGLbc7EBrh8umiyg2KAhj1eTDPtMNu5Tg5wE+w@mail.gmail.com>
In-Reply-To: <xmqqh89ydhqu.fsf@gitster-ct.c.googlers.com>

Hi Junio,

Junio C Hamano <gitster@pobox.com> 於 2019年5月13日 週一 下午1:51寫道：

Show 20 quoted lines

>
> 林自均 <johnlinp@gmail.com> writes:
>
> > Hi Junio,
> >> ...
> > Could you please give me some advice on my patch? Thank you.
>
> I tend to agree with what Phillip said in
> <ae1332b8-a227-e83a-8862-8811b6a81251@gmail.com>.
>
> If the difference between "status" and "commit" bothers you so much,
> i.e.
>
>     When typing "git status", there is an empty line between the
>     "Changes not staged for commit:" block and the list of changed
>     files. However, when typing "git commit" with no files added,
>     there are no empty lines between them.
>
> it may not be a bad idea to try making them consistent by removing
> the blank line that is given after the advice messages, perhaps?

Thank you for the review. I guess removing the blank line also work for me. I'll submit another patch.

Best, John Lin