Re: [PATCH v4 2/3] pretty: add tag option to %(describe)

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 31, 2021, 18:07 UTC
Message-ID: <xmqqh7cxdq4k.fsf@gitster.g>
In-Reply-To: <20211031171510.1646396-3-eschwartz@archlinux.org>

Eli Schwartz <eschwartz@archlinux.org> writes:

Show 12 quoted lines

> The %(describe) placeholder by default, like `git describe`, only
> supports annotated tags. However, some people do use lightweight tags
> for releases, and would like to describe those anyway. The command line
> tool has an option to support this.
>
> Teach the placeholder to support this as well.
>
> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
> ---
>
> I use lowercase "bool" here not "boolean-value" because I don't see
> utility in the word "value" here.

Such a comment is much more useful if it is sent as a review to the patch that touches the same area as your patch does, namely,

https://lore.kernel.org/git/984b6d687a2e779c775de6ea80536afe6ecc0aaf.1635438124.git.gitgitgadget@gmail.com/

not here.

Thanks.

[jc: added a few folks involved in the other patch to the addressee lists]