Re: [PATCH v2 3/3] pretty: add abbrev option to %(describe)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 26, 2021, 17:28 UTC
Message-ID: <CAPig+cQoNJpzpL_DYiDFFbZzKwRbwJzuS4+fUcwZ_OLx8onHtA@mail.gmail.com>
In-Reply-To: <YXfvY3n9wEwctjUR@danh.dev>

On Tue, Oct 26, 2021 at 8:07 AM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

Show 14 quoted lines

> On 2021-10-25 21:34:52-0400, Eli Schwartz <eschwartz@archlinux.org> wrote:
> > +                                     if (!arglen)
> > +                                             return 0;
> > +                                     char* endptr;
>
> Other than the question pointed out by Eric,
>
> with DEVELOPER=1, -Werror=declaration-after-statement
> We'll need this change squashed in:
>
> +                                       char* endptr;
>                                         if (!arglen)
>                                                 return 0;
> -                                       char* endptr;

This highlights a style nit, as well; should be:

    char *endptr;

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.