Re: [PATCH v3 3/3] pretty: add abbrev option to %(describe)
- From
Eli Schwartz <eschwartz@archlinux.org>
- Date
- Oct 29, 2021, 19:04 UTC
- Message-ID
- <3c3cc160-fe7a-30c1-d65e-209dcc07d76e@archlinux.org>
- In-Reply-To
- <CAPig+cSvecU9XSVobxSO-72rFgAMh5D39UcS6SJ2=xFVvnGJBA@mail.gmail.com>
On 10/29/21 2:51 PM, Eric Sunshine wrote:
Show 23 quoted lines
> On Fri, Oct 29, 2021 at 2:45 PM Eli Schwartz <eschwartz@archlinux.org> wrote: >> The %(describe) placeholder by default, like `git describe`, uses a >> seven-character abbreviated commit object name. This may not be >> sufficient to fully describe all commits in a given repository, >> resulting in a placeholder replacement changing its length because the >> repository grew in size. This could cause the output of git-archive to >> change. >> >> Add the --abbrev option to `git describe` to the placeholder interface >> in order to provide tools to the user for fine-tuning project defaults >> and ensure reproducible archives. >> [...] >> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> >> --- >> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt >> @@ -222,6 +222,10 @@ The placeholders are: >> +** 'abbrev=<N>': Instead of using the default number of hexadecimal digits >> + (which will vary according to the number of objects in the repository with a >> + default of 7) of the abbreviated object name, use <n> digits, or as many digits >> + as needed to form a unique object name. > > There's still an inconsistent mix of `<N>` and `<n>` here (mentioned > in my earlier review). Is that intentional or just a simple oversight?
Ah, sorry... I overlooked that. It was originally copied from the git-describe man page which uses lowercase and I overlooked that part of your review.
It should be consistently uppercase here for consistency with pretty-formats.
-- Eli Schwartz Arch Linux Bug Wrangler and Trusted User