Re: [PATCH v3 2/3] pretty: add tag option to %(describe)

From: Eli Schwartz <eschwartz@archlinux.org>
Date: Oct 29, 2021, 21:14 UTC
Message-ID: <3cf891ea-58c8-b7d5-0b6e-eb23dff92bd5@archlinux.org>
In-Reply-To: <xmqqy26bk2k9.fsf@gitster.g>

On 10/29/21 4:18 PM, Junio C Hamano wrote:

Show 16 quoted lines

> Eli Schwartz <eschwartz@archlinux.org> writes:
> 
>>  +
>> +** 'tags[=<BOOL>]': Instead of only considering annotated tags,
>> +   consider lightweight tags as well.
> 
> This part contradicts what Jean-Noël's df34a41f is trying to
> achieve, which can be seen in these hunks from it:
>
> [...]
> 
> So, let's instead use
> 
>     tags[=<bool-value>]: Instead of only considering ...
> 
> i.e. lowercase, with -value suffix.

An interesting change. I can use that description style, sure. Though I will note the commit message for it talks a lot about replacing spaces with hyphens, and very little about consolidating on case *or* using different language such as:

-* 'format:<string>' +* 'format:<format-string>'

I also assume that it's fine for my patches to be inconsistent with the base commit, as it's expected df34a41f or some revision of it will be merged around the same time?

-- 
Eli Schwartz
Arch Linux Bug Wrangler and Trusted User