Re: [PATCH v3] git-prompt: make colourization consistent

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2022, 20:50 UTC
Message-ID: <xmqqh751eakm.fsf@gitster.g>
In-Reply-To: <7d391d82-b15e-4a31-5207-c4037fec0bf9@online.no>

Joakim Petersen <joak-pet@online.no> writes:

Show 5 quoted lines

> That does seem like a much better idea for maintainability, I can
> change the patch to do this instead. I have one question, though: the
> sequence $c$b (bare state and branch name) is a special case, where
> they're intended to have the same colour, should I wrap both in colour
> set, colour clear, or only clear after $b?

If we want to allow $c and $b appear in different places (which I have no opinion on), I would say we should just color them independently and fix the test that expects the close linkage between the two. I offhand see no reason that they _must_ stay together myself, though.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.