Re: [RFC PATCH] git-prompt: make colourization consistent

From: Joakim Petersen <joak-pet@online.no>
Date: Jun 1, 2022, 18:26 UTC
Message-ID: <df854e0b-3731-0b7e-557e-9446578da0e9@online.no>
In-Reply-To: <220601.864k141ls0.gmgdl@evledraar.gmail.com>

On 01/06/2022 16:47, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> This seems to make sense to me, but I haven't looked deeply into it. But
> let's CC the author of 0ec7c23cdc6 (git-prompt: make upstream state
> indicator location consistent, 2022-02-27) (which I've done here).
> 
> For a non-RFC patch I think a rephrasing of most of what yo uhave below
> "--" should be part of the message. Note how I referred to the
> 0ec... commit above, you should reference the commit like that (see
> SubmittingPatches).
> 
> Thanks for working on this fix!
>  >

Thanks for the pointers, I'll keep that in mind for the follow-up! I do have one question regarding the procedure for the follow-up, though: If there are no code changes, should it still be submitted as a "v2"?