Re: [PATCH v3] git-prompt: make colourization consistent
- From
Joakim Petersen <joak-pet@online.no>
- Date
- Jun 3, 2022, 18:51 UTC
- Message-ID
- <9fa34f22-3404-7bf8-6985-642c80634bf8@online.no>
- In-Reply-To
- <7d391d82-b15e-4a31-5207-c4037fec0bf9@online.no>
On 03/06/2022 19:23, Joakim Petersen wrote:
Show 9 quoted lines
> That does seem like a much better idea for maintainability, I can > change the patch to do this instead. I have one question, though: the > sequence $c$b (bare state and branch name) is a special case, where > they're intended to have the same colour, should I wrap both in colour > set, colour clear, or only clear after $b? The former requires rewriting > the tests or changing $gitstring to not include $c when $c is empty, > while the latter keeps the tests unchanged, but may pose a problem if > "BARE:" should at any point not appear immediately before the branch > name.
Sorry, the former (colourizing and clearing $c and $b individually) requires rewriting tests no matter what.