Re: [PATCH] Allow git-config to append a comment

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2024, 13:27 UTC
Message-ID: <xmqqh6hinpd7.fsf@gitster.g>
In-Reply-To: <87plw6xld7.fsf@ra.horus-it.com>

Ralph Seichter <ralph@seichter.de> writes:

Show 5 quoted lines

> Just as a brief interjection: I am sorry that my inexperience with Git's
> mailing-list based process caused me to leave out details which were
> discussed earlier, be it on GitHub or Discord. However, me not
> mentioning that I am aiming for single-line suffix comments only was due
> to simple forgetfulness, without an excuse behind it. My bad.

Don't feel too bad. It is not about discord vs mailing list vs github "reviews on the web". It is about the end-product, the commit log messages, what future developers will see in their "git log" output.

> I think it best I flesh out the commit message before anything else, and
> then resubmit. That should bundle the necessary information.

Yup.  Please do that.

Communicating with reviewers and other contributors is not the primary goal of the review process. It is done to help us reach a better end-product, the commit log messages that will help our future developers and future selves.

Thanks.