Re: [PATCH 3/1] config: allow tweaking whitespace between value and comment

From: Dragan Simic <dsimic@manjaro.org>
Date: Mar 27, 2024, 01:23 UTC
Message-ID: <8d05e767aa5ba30e91522835fb2941b8@manjaro.org>
In-Reply-To: <871q7wv7s1.fsf@ra.horus-it.com>

Hello Ralph,

On 2024-03-27 01:27, Ralph Seichter wrote:

Show 20 quoted lines

> * Junio C. Hamano:
> 
>> The easiest would have been for you to say "Yup, the two additional
>> patches queued on top of mine seem to make it better. [...]
> 
> Would it? Well, you wrote the following two weeks ago, among other
> things:
> 
>>> I thought we already discussed this and unconditional "#comment" has
>>> already been declared a non starter.
> 
> This unilateral decision of yours, and the following prolonged debate
> about spaces/tabs (which I clearly stated I consider a waste of time)
> left me with the impression that what I think doesn't matter much
> anyway. Also, it seems to me that this whole subject has already been
> blown far out of proportion. If this exercise leads to the feature I 
> was
> proposing, you guys can do whatever, and I won't slow things down by
> expressing my opinions, or by continuing to formulate my own commit
> messages. So much time has already been spent.

Well, is getting patches accepted to git hard and often challenging? Absolutely. Do additional patches and discussions sprout all over the place? They obviously do. But, does a high-profile open-source project deserve such an approach? Without doubt.

In fact, pretty much every good software project should employ such an approach, but that unfortunately isn't always the case.

That's how I see it.