RE: [PATCH] Allow git-config to append a comment

From: Ralph Seichter <github@seichter.de>
Date: Mar 7, 2024, 15:57 UTC
Message-ID: <87wmqevxur.fsf@ra.horus-it.com>
In-Reply-To: <09c501da70a5$bd2f4f40$378dedc0$@nexbridge.com>

* rsbecker@nexbridge.com:

> My purpose is just to highlight, for the purpose of reviewing the
> change, that there may be unintended impacts, that's all.

I see. Have you perhaps spotted a flaw in the patch which might cause problems? If so, I'd like to address it.

> With git config moving comments around, responsibility shifts to git -
> a.k.a., unintended consequences.

It is important to note that my implementation does not engage in "moving comments around" at all. It merely supports adding comment suffixes to config lines *while they are created by git-config*. No after-the-fact comment manipulation is done. There are no multiline comments involved either, which I should have mentioned from the get-go. The limited scope of my proposal is deliberate, and aimed at avoiding possible problems based on the design alone.

-Ralph