Re: [PATCH v2] config: add --comment option to add a comment

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 11, 2024, 21:31 UTC
Message-ID: <xmqq7ci8pi9d.fsf@gitster.g>
In-Reply-To: <349b8a67931a2fddfff35db393023bf0@manjaro.org>

Dragan Simic <dsimic@manjaro.org> writes:

> However, I think there should be some way to allow the users to choose
> the kind of spacing between the automatically added comments and their
> respective values.  Yes, readability may be subjective, but I think
> that the users should be allowed some kind of choice.

As to the whitespace _before_ the '#', we can just pick one and leave the choice to users' editor, which they have to resort to anyway for even trivial things like fixing typos. I am fine to defer the choice between HT and SP to Ralph as the person in the driver seat,

As to the whitespace _after_ the '#', I would say we have obligation to the users to be consistent with other codepaths that we already write our own comments. "# " is the only sensible choice of the default there, and we can allow other styles as I outlined in a separate message if we wanted to.