git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] chainlint.pl: fix incorrect CPU count on Linux SPARC

From
Junio C Hamano <gitster@pobox.com>
Date
May 22, 2024, 19:00 UTC
Message-ID
<xmqqh6ep4qoy.fsf@gitster.g>
In-Reply-To
<CAPig+cTfqk+tbTAVyPj8YP1uHx1D1swL84h-4p6OKBV=dDRX_Q@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 12 quoted lines
>> > > "CPUnn:" in /proc/cpuinfo instead of the usual "processor NN:".
>> >
>> > not sure if worth a reroll, but the "usual" syntax is "processor  : NN"
> ...
> Inclusion of the word "usual" is such a minor flaw in the commit
> message that I doubt it warrants a reroll and the associated cost on
> reviewers and on the maintainer (Junio), especially since it does not
> negatively impact the intent conveyed by the commit messages nor the
> correctness of the actual patch.
>
> As such, I'm not worried about it. Whether Junio reads this and wants
> to correct it in his tree is up to him, of course.

I think "usual" is not what was pointed out. The order between the colon and NN is.

Previous: Eric SunshineNext: Eric Sunshine
Message 13 of 23 in “chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARC”
  1. chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARCJohn Paul Adrian Glaubitz, May 20, 2024
  2. Junio C HamanoMay 20, 2024
  3. John Paul Adrian GlaubitzMay 20, 2024
  4. Eric SunshineMay 20, 2024
  5. Eric SunshineMay 20, 2024
  6. Eric SunshineMay 20, 2024
  7. Junio C HamanoMay 20, 2024
  8. 0/3 improve chainlint.pl CPU count computationEric Sunshine, May 20, 2024
  9. 2/3 chainlint.pl: fix incorrect CPU count on Linux SPARCEric Sunshine, May 20, 2024
  10. Carlo Marcelo Arenas BelónMay 22, 2024
  11. John Paul Adrian GlaubitzMay 22, 2024
  12. Eric SunshineMay 22, 2024
  13. Junio C HamanoMay 22, 2024
  14. Eric SunshineMay 22, 2024
  15. John Paul Adrian GlaubitzMay 27, 2024
  16. Eric SunshineMay 27, 2024
  17. 3/3 chainlint.pl: latch CPU count directly reported by /proc/cpuinfoEric Sunshine, May 20, 2024
  18. 1/3 chainlint.pl: make CPU count computation more robustEric Sunshine, May 20, 2024
  19. John Paul Adrian GlaubitzMay 20, 2024
  20. Eric SunshineMay 20, 2024
  21. John Paul Adrian GlaubitzMay 20, 2024
  22. John Paul Adrian GlaubitzMay 21, 2024
  23. Eric SunshineMay 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.