git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/3] chainlint.pl: latch CPU count directly reported by /proc/cpuinfo

From
ESEric Sunshine <ericsunshine@charter.net>
Date
May 20, 2024, 19:01 UTC
Message-ID
<20240520190131.94904-4-ericsunshine@charter.net>
In-Reply-To
<20240520190131.94904-1-ericsunshine@charter.net>
From: Eric Sunshine <sunshine@sunshineco.com>

On Linux, ncores() computes the number of CPUs by counting the "processor" or "CPU" lines emitted by /proc/cpuinfo. However, on some platforms, /proc/cpuinfo does not enumerate the CPUs at all, but instead merely mentions the total number of CPUs. In such cases, pluck the CPU count directly from the /proc/cpuinfo line which reports the number of active CPUs. (In particular, check for "cpus active: NN" and "ncpus active: NN" since both variants have been seen in the wild[1,2].)

[1]: https://lore.kernel.org/git/503a99f3511559722a3eeef15d31027dfe617fa1.camel@physik.fu-berlin.de/ [2]: https://lore.kernel.org/git/7acbd5c6c68bd7ba020e2d1cc457a8954fd6edf4.camel@physik.fu-berlin.de/

Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
 t/chainlint.pl | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/t/chainlint.pl b/t/chainlint.pl
index d593cb95e7..1bbd985b78 100755
--- a/t/chainlint.pl
+++ b/t/chainlint.pl
@@ -724,6 +724,9 @@ sub ncores {
 	if (open my $fh, '<', '/proc/cpuinfo') {
 		my $cpuinfo = do { local $/; <$fh> };
 		close($fh);
+		if ($cpuinfo =~ /^n?cpus active\s*:\s*(\d+)/m) {
+			return $1 if $1 > 0;
+		}
 		my @matches = ($cpuinfo =~ /^(processor|CPU)[\s\d]*:/mg);
 		return @matches ? scalar(@matches) : 1;
 	}
-- 
2.45.1
Previous: Eric SunshineNext: Eric Sunshine
Message 17 of 23 in “chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARC”
  1. chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARCJohn Paul Adrian Glaubitz, May 20, 2024
  2. Junio C HamanoMay 20, 2024
  3. John Paul Adrian GlaubitzMay 20, 2024
  4. Eric SunshineMay 20, 2024
  5. Eric SunshineMay 20, 2024
  6. Eric SunshineMay 20, 2024
  7. Junio C HamanoMay 20, 2024
  8. 0/3 improve chainlint.pl CPU count computationEric Sunshine, May 20, 2024
  9. 2/3 chainlint.pl: fix incorrect CPU count on Linux SPARCEric Sunshine, May 20, 2024
  10. Carlo Marcelo Arenas BelónMay 22, 2024
  11. John Paul Adrian GlaubitzMay 22, 2024
  12. Eric SunshineMay 22, 2024
  13. Junio C HamanoMay 22, 2024
  14. Eric SunshineMay 22, 2024
  15. John Paul Adrian GlaubitzMay 27, 2024
  16. Eric SunshineMay 27, 2024
  17. 3/3 chainlint.pl: latch CPU count directly reported by /proc/cpuinfoEric Sunshine, May 20, 2024
  18. 1/3 chainlint.pl: make CPU count computation more robustEric Sunshine, May 20, 2024
  19. John Paul Adrian GlaubitzMay 20, 2024
  20. Eric SunshineMay 20, 2024
  21. John Paul Adrian GlaubitzMay 20, 2024
  22. John Paul Adrian GlaubitzMay 21, 2024
  23. Eric SunshineMay 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.