git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARC

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 20, 2024, 17:07 UTC
Message-ID
<CAPig+cSGjE69N0TpB4ub7vY5fXHpDJ6j4-xet8G1zcgRo4OHHA@mail.gmail.com>
In-Reply-To
<CAPig+cQsc4AUJ7-0v=rS8VVK9JG1+_iSwa_gWUUigs=uwYq6Lw@mail.gmail.com>
On Mon, May 20, 2024 at 12:50 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 21 quoted lines
> On Mon, May 20, 2024 at 12:16 PM Junio C Hamano <gitster@pobox.com> wrote:
> >         # Windows
> >         return $ENV{NUMBER_OF_PROCESSORS} if exists($ENV{NUMBER_OF_PROCESSORS});
> >         # Linux / MSYS2 / Cygwin / WSL
> > -       do { local @ARGV='/proc/cpuinfo'; return scalar(grep(/^processor[\s\d]*:/, <>)); } if -r '/proc/cpuinfo';
> > +       do {
> > +               local @ARGV='/proc/cpuinfo';
> > +               my @num = grep(/^processor[\s\d]*:|^CPU[\d]*:/, <>);
> > +# print STDERR "FOUND <@num>\n";
> > +               return 1 if (!@num);
> > +               return scalar(@num);
> > +       } if -r '/proc/cpuinfo';
> >         # macOS & BSD
> >         return qx/sysctl -n hw.ncpu/ if $^O =~ /(?:^darwin$|bsd)/;
> >         return 1;
>
> I had a more all-inclusive change in mind. These number-of-cpu checks
> are in order from least to most costly but they are not necessarily
> mutually exclusive. As such, my thinking was that the logic would fall
> through to the next check if the preceding check produced zero or
> nonsense.

Hmph. Looking at this more closely, I guess I did make these more mutually-exclusive than I had thought, so falling through to the next check probably doesn't buy us much. In any case, for robustness, I still think that each check needs to have a sensible fallback. An alternative would be for the caller of ncores() to fallback to 1 if ncores() returns 0 (or nonsense).

Previous: Eric SunshineNext: Junio C Hamano
Message 6 of 23 in “chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARC”
  1. chainlint.pl: Extend regexp pattern for /proc/cpuinfo on Linux SPARCJohn Paul Adrian Glaubitz, May 20, 2024
  2. Junio C HamanoMay 20, 2024
  3. John Paul Adrian GlaubitzMay 20, 2024
  4. Eric SunshineMay 20, 2024
  5. Eric SunshineMay 20, 2024
  6. Eric SunshineMay 20, 2024
  7. Junio C HamanoMay 20, 2024
  8. 0/3 improve chainlint.pl CPU count computationEric Sunshine, May 20, 2024
  9. 2/3 chainlint.pl: fix incorrect CPU count on Linux SPARCEric Sunshine, May 20, 2024
  10. Carlo Marcelo Arenas BelónMay 22, 2024
  11. John Paul Adrian GlaubitzMay 22, 2024
  12. Eric SunshineMay 22, 2024
  13. Junio C HamanoMay 22, 2024
  14. Eric SunshineMay 22, 2024
  15. John Paul Adrian GlaubitzMay 27, 2024
  16. Eric SunshineMay 27, 2024
  17. 3/3 chainlint.pl: latch CPU count directly reported by /proc/cpuinfoEric Sunshine, May 20, 2024
  18. 1/3 chainlint.pl: make CPU count computation more robustEric Sunshine, May 20, 2024
  19. John Paul Adrian GlaubitzMay 20, 2024
  20. Eric SunshineMay 20, 2024
  21. John Paul Adrian GlaubitzMay 20, 2024
  22. John Paul Adrian GlaubitzMay 21, 2024
  23. Eric SunshineMay 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.