Re: [PATCH 14/20] config: pass repo to `git_config_get_expiry_in_days()`

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 9, 2024, 21:14 UTC
Message-ID: <xmqqh6btbdqz.fsf@gitster.g>
In-Reply-To: <qo26pmkrctepcob4vjfimvxlgoic7gqjxasnz2hqmv4hpgc37t@jh5wo2fjqyoo>

Justin Tobler <jltobler@gmail.com> writes:

Show 14 quoted lines

> On 24/08/07 08:57AM, Patrick Steinhardt wrote:
>> Refactor `git_config_get_expiry_in_days()` to accept a `struct
>> repository` such that we can get rid of the implicit dependency on
>> `the_repository`. Rename the function accordingly.
>> 
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
> [snip]
>> -	git_config_get_expiry_in_days("gc.rerereresolved", &cutoff_resolve, now);
>> -	git_config_get_expiry_in_days("gc.rerereunresolved", &cutoff_noresolve, now);
>> +	repo_config_get_expiry_in_days(the_repository, "gc.rerereresolved", &cutoff_resolve, now);
>> +	repo_config_get_expiry_in_days(the_repository, "gc.rerereunresolved", &cutoff_noresolve, now);
>
> non-blocking: Do we want to fold these lines?

Yes, if we are going to see another iteration for other reasons.