Re: [PATCH 14/20] config: pass repo to `git_config_get_expiry_in_days()`

From: Justin Tobler <jltobler@gmail.com>
Date: Aug 9, 2024, 20:21 UTC
Message-ID: <qo26pmkrctepcob4vjfimvxlgoic7gqjxasnz2hqmv4hpgc37t@jh5wo2fjqyoo>
In-Reply-To: <cf7942479f75d95dcd8606b0947a8897ae60da60.1723013714.git.ps@pks.im>

On 24/08/07 08:57AM, Patrick Steinhardt wrote:

Show 6 quoted lines

> Refactor `git_config_get_expiry_in_days()` to accept a `struct
> repository` such that we can get rid of the implicit dependency on
> `the_repository`. Rename the function accordingly.
> 
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---

[snip]

> -	git_config_get_expiry_in_days("gc.rerereresolved", &cutoff_resolve, now);
> -	git_config_get_expiry_in_days("gc.rerereunresolved", &cutoff_noresolve, now);
> +	repo_config_get_expiry_in_days(the_repository, "gc.rerereresolved", &cutoff_resolve, now);
> +	repo_config_get_expiry_in_days(the_repository, "gc.rerereunresolved", &cutoff_noresolve, now);

non-blocking: Do we want to fold these lines?

>  	git_config(git_default_config, NULL);
>  	dir = opendir(git_path("rr-cache"));
>  	if (!dir)