Re: [PATCH v2 00/20] Memory leak fixes (pt.5)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2024, 19:01 UTC
Message-ID: <xmqqh6bcqt5e.fsf@gitster.g>
In-Reply-To: <cover.1724315484.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 16 quoted lines

> this is version 2 of this patch series that fixes another set of memory
> leaks.
>
> Changes compared to v1:
>
>   - Remove spaces between cast and variable.
>
>   - Clarify why we move the `ctx.entries_nr` block.
>
>   - Adapt sideband colors to use `git_config_get_string_tmp()` such that
>     we do not have to allocate the strings in the first place.
>
>   - Fix more memory leaks for config values in the remote state.
>
>   - Refactor `unbundle()` to not free extra args passed by the caller
>     anymore. Instead, this is now always done by the caler.

All these changes look sensible to me.

Let me wait for a few days for others' comments, and then mark the topic for 'next'.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.